[
https://issues.apache.org/jira/browse/NIFI-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494634#comment-16494634
]
ASF GitHub Bot commented on NIFI-5122:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2663#discussion_r191634954
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/resources/docs/org.apache.nifi.reporting.SiteToSiteStatusReportingTask/additionalDetails.html
---
@@ -50,7 +50,7 @@ <h2>Record writer</h2>
{ "name" : "actorHostname", "type" : "string"},
{ "name" : "componentType", "type" : "string"},
{ "name" : "componentName", "type" : "string"},
- { "name" : "parentId", "type" : "string"},
+ { "name" : "parentId", "type" : ["string", "null"]},
--- End diff --
That looks VERY familiar but I think even the first time we dealt with Avro
it might have been 1.7.x after it had been fixed (plus that had to do with
default values being supported with unions). Maybe I'm thinking of a NiFi
Record API bug with unions and defaults. But either way, if this LGTY it LGTM :)
> Add record writer to S2S Reporting Tasks
> ----------------------------------------
>
> Key: NIFI-5122
> URL: https://issues.apache.org/jira/browse/NIFI-5122
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Priority: Major
>
> Just like we have the option to specify a record writer for the new Site To
> Site Metrics Reporting Task, there should be the possibility to specify an
> optional record writer for the other S2S reporting tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
