GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2747
NIFI-5249 Dockerfile enhancements
- Createdata repository and log directories
- Add explicit environment variable declarations to replace nifi-env.sh
- Remove obsolete chown commands after user has already been switched to
nifi
How I tested the changes:
- I've ran `mvn package -P docker` in the nifi-docker folder to build the
image.
- I've made sure that `docker run --rm -ti apache/nifi` runs and start nifi
using the new image
- Made sure that all files are owned by the nifi user under /opt/nifi:
`docker run --rm -ti --entrypoint /bin/bash apache/nifi -c "find /opt/nifi !
-user nifi"`
- Checked that the expected environment variables are set:
```
docker run --rm -ti --entrypoint /bin/bash apache/nifi -c "env | grep NIFI"
NIFI_HOME=/opt/nifi/nifi-1.7.0-SNAPSHOT
NIFI_LOG_DIR=/opt/nifi/nifi-1.7.0-SNAPSHOT/logs
NIFI_PID_DIR=/opt/nifi/nifi-1.7.0-SNAPSHOT/run
NIFI_BASE_DIR=/opt/nifi
```
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pepov/nifi NIFI-5249
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2747.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2747
----
commit fb0b515c565cc532169a03eb7c4a59027d818718
Author: pepov <peterwilcsinszky@...>
Date: 2018-05-29T11:27:45Z
NIFI-5249 Dockerfile enhancements: create data repository and log
directories, explicit environment variable declarations to replace nifi-env.sh
----
---
