[ 
https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496789#comment-16496789
 ] 

ASF GitHub Bot commented on MINIFICPP-517:
------------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155481
  
    --- Diff: extensions/sensors/SensorLoader.cpp ---
    @@ -0,0 +1,30 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#include "SensorLoader.h"
    +
    +#include "core/FlowConfiguration.h"
    +
    +bool SensorFactory::added = 
core::FlowConfiguration::add_static_func("createSensorFactory");
    +
    +extern "C" {
    +
    +void *createSensorFactory(void) {
    +  return new SensorFactory();
    --- End diff --
    
    Maybe return a moved unique_ptr to make ownership semantics clearer?


> Port sensor reading processors
> ------------------------------
>
>                 Key: MINIFICPP-517
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-517
>             Project: NiFi MiNiFi C++
>          Issue Type: New Feature
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Major
>
> Begin building the sensor reading package. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to