Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192165818
  
    --- Diff: libminifi/test/unit/YamlConfigurationTests.cpp ---
    @@ -457,3 +456,64 @@ Flow Controller:
       REQUIRE(NULL != rootFlowConfig->findProcessor("XYZ")->getUUID());
       REQUIRE(!rootFlowConfig->findProcessor("XYZ")->getUUIDStr().empty());
     }
    +
    +class DummyComponent : public core::ConfigurableComponent {
    --- End diff --
    
    let's leave override out of libminifi/ and keep it in extensions due to 
compiler versioning. 


---

Reply via email to