[
https://issues.apache.org/jira/browse/NIFI-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500991#comment-16500991
]
ASF GitHub Bot commented on NIFI-5209:
--------------------------------------
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/2761
NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.
This feature was added to support external integration with Apache Ambari.
Ambari developers then discovered a problem with the joint proposal and we
built a different way to accomplish the goal. This behavior should be removed
so it does not go in a release and need to be supported unnecessarily.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-5209
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2761
----
commit 51822b8569d21965c3cf91f7f1ae2758285adf44
Author: Andy LoPresto <alopresto@...>
Date: 2018-06-04T19:39:34Z
NIFI-5209 Removed secure hash functionality from ConfigEncryptionTool.
Removed relevant unit tests.
----
> Remove toolkit migration without password functionality
> -------------------------------------------------------
>
> Key: NIFI-5209
> URL: https://issues.apache.org/jira/browse/NIFI-5209
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.7.0
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Priority: Major
> Labels: hash, key, passwords, revert, security, toolkit
>
> In NIFI-4942, new functionality was added to allow Ambari clients to perform
> the encrypted configuration migration without providing the original password
> or key by using a secure hash of the original credential to demonstrate
> knowledge of that value. The Ambari team found another way on their end to
> perform this action, and rather than allow the {{./secure_hash.key}} behavior
> to be released and then removed at a later time, complicating our security
> posture and potentially creating difficult support cases, it is better to
> remove it completely before the 1.7.0 release.
> However, it is not as simple as just backing out a few commits, as necessary
> refactoring of the tool code also occurred at that time. I will remove this
> feature while maintaining the improvements made to the toolkit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
