[
https://issues.apache.org/jira/browse/NIFI-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501115#comment-16501115
]
ASF GitHub Bot commented on NIFI-5268:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2762
NIFI-5268: Fix JostTransformJSON spec validation with EL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-5268
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2762
----
commit df3c78478210e9187c9101f17f5009b37ee71242
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-06-05T01:21:17Z
NIFI-5268: Fix JostTransformJSON spec validation with EL
----
> JoltTransformJSON specification property fails with EL
> ------------------------------------------------------
>
> Key: NIFI-5268
> URL: https://issues.apache.org/jira/browse/NIFI-5268
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Major
>
> This issue is originally reported at
> https://community.hortonworks.com/questions/196223/jolttransformjson-specification-property-fails-wit.html
> There is a wrong if statement in how JoltTransformJSON validates the spec
> when it contains EL. The processor tries to check if the JoltSpec contains
> any custom transformation class to fail fast, but it fails to get a JoltSpec
> because EL can not return a valid spec at the validation phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
