[
https://issues.apache.org/jira/browse/NIFI-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502253#comment-16502253
]
ASF GitHub Bot commented on NIFI-5260:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2764
NIFI-5260 Adding version elements in archetypes for dependencies that…
… previously were under dependencyManagement
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-5260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2764
----
commit a1a02ae5da0dde2d62f617ea4e094ee67661e23c
Author: Bryan Bende <bbende@...>
Date: 2018-06-05T18:27:59Z
NIFI-5260 Adding version elements in archetypes for dependencies that
previously were under dependencyManagement
----
> Regression in nifi-processor-bundle-archetype
> ---------------------------------------------
>
> Key: NIFI-5260
> URL: https://issues.apache.org/jira/browse/NIFI-5260
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.6.0
> Environment: Maven v3.2.1
> Debian GNU/Linux 9.4 (stretch)
> Reporter: Paul Millar
> Priority: Major
>
> Using
> {{mvn archetype:generate -DarchetypeGroupId=org.apache.nifi
> -DarchetypeArtifactId=nifi-processor-bundle-archetype
> -DarchetypeVersion=1.6.0 -DnifiVersion=1.6.0}}
> I generated an initial processor bundle package. Here is the output
> {{ paul@sparkplug:~/git/Nifi$ mvn archetype:generate
> -DarchetypeGroupId=org.apache.nifi
> -DarchetypeArtifactId=nifi-processor-bundle-archetype
> -DarchetypeVersion=1.6.0 -DnifiVersion=1.6.0}}
> {{[INFO] Scanning for projects...}}
> {{[INFO] }}
> {{[INFO] Using the builder
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder
> with a thread count of 1}}
> {{[INFO]
> }}
> {{[INFO]
> ------------------------------------------------------------------------}}
> {{[INFO] Building Maven Stub Project (No POM) 1}}
> {{[INFO]
> ------------------------------------------------------------------------}}
> {{[INFO] }}
> {{[INFO] >>> maven-archetype-plugin:3.0.1:generate (default-cli) @
> standalone-pom >>>}}
> {{[INFO] }}
> {{[INFO] <<< maven-archetype-plugin:3.0.1:generate (default-cli) @
> standalone-pom <<<}}
> {{[INFO] }}
> {{[INFO] --- maven-archetype-plugin:3.0.1:generate (default-cli) @
> standalone-pom ---}}
> {{[INFO] Generating project in Interactive mode}}
> {{[INFO] Archetype repository not defined. Using the one from
> [org.apache.nifi:nifi-processor-bundle-archetype:1.6.0] found in catalog
> remote}}
> {{Define value for property 'groupId': org.dcache.nifi}}
> {{Define value for property 'artifactId': nifi-sse-bundle}}
> {{Define value for property 'version' 1.0-SNAPSHOT: : }}
> {{Define value for property 'artifactBaseName': sse}}
> {{Define value for property 'package' org.dcache.nifi.processors.sse: : }}
> {{[INFO] Using property: nifiVersion = 1.6.0}}
> {{Confirm properties configuration:}}
> {{groupId: org.dcache.nifi}}
> {{artifactId: nifi-sse-bundle}}
> {{version: 1.0-SNAPSHOT}}
> {{artifactBaseName: sse}}
> {{package: org.dcache.nifi.processors.sse}}
> {{nifiVersion: 1.6.0}}
> {{ Y: : }}
> {{[INFO]
> ----------------------------------------------------------------------------}}
> {{[INFO] Using following parameters for creating project from Archetype:
> nifi-processor-bundle-archetype:1.6.0}}
> {{[INFO]
> ----------------------------------------------------------------------------}}
> {{[INFO] Parameter: groupId, Value: org.dcache.nifi}}
> {{[INFO] Parameter: artifactId, Value: nifi-sse-bundle}}
> {{[INFO] Parameter: version, Value: 1.0-SNAPSHOT}}
> {{[INFO] Parameter: package, Value: org.dcache.nifi.processors.sse}}
> {{[INFO] Parameter: packageInPathFormat, Value:
> org/dcache/nifi/processors/sse}}
> {{[INFO] Parameter: package, Value: org.dcache.nifi.processors.sse}}
> {{[INFO] Parameter: artifactBaseName, Value: sse}}
> {{[INFO] Parameter: version, Value: 1.0-SNAPSHOT}}
> {{[INFO] Parameter: groupId, Value: org.dcache.nifi}}
> {{[INFO] Parameter: artifactId, Value: nifi-sse-bundle}}
> {{[INFO] Parameter: nifiVersion, Value: 1.6.0}}
> {{[INFO] Project created from Archetype in dir:
> /home/paul/git/Nifi/nifi-sse-bundle}}
> {{[INFO]
> ------------------------------------------------------------------------}}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO]
> ------------------------------------------------------------------------}}
> {{[INFO] Total time: 53.334 s}}
> {{[INFO] Finished at: 2018-06-03T09:03:43+01:00}}
> {{[INFO] Final Memory: 19M/223M}}
> {{[INFO]
> ------------------------------------------------------------------------}}
> {{paul@sparkplug:~/git/Nifi$}}
> However, when I try to build the generated projects, I see a dependency error
> {{paul@sparkplug:~/git/Nifi$ cd nifi-sse-bundle/}}
> {{paul@sparkplug:~/git/Nifi/nifi-sse-bundle$ mvn package}}
> {{[INFO] Scanning for projects...}}
> {{[ERROR] The build could not read 1 project -> [Help 1]}}
> {{[ERROR] }}
> {{[ERROR] The project org.dcache.nifi:nifi-sse-processors:1.0-SNAPSHOT
> (/home/paul/git/Nifi/nifi-sse-bundle/nifi-sse-processors/pom.xml) has 2
> errors}}
> {{[ERROR] 'dependencies.dependency.version' for
> org.apache.nifi:nifi-utils:jar is missing. @ line 33, column 21}}
> {{[ERROR] 'dependencies.dependency.version' for
> org.apache.nifi:nifi-mock:jar is missing. @ line 37, column 21}}
> {{[ERROR] }}
> {{[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.}}
> {{[ERROR] Re-run Maven using the -X switch to enable full debug logging.}}
> {{[ERROR] }}
> {{[ERROR] For more information about the errors and possible solutions,
> please read the following articles:}}
> {{[ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException}}
> {{paul@sparkplug:~/git/Nifi/nifi-sse-bundle$ }}
> The same operations work when using nifi-process-bundle-archetype v1.5.0
> It seems that Nifi v1.6.0 introduced a required property
> dependencies.dependency.version that has no default value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
