Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2758#discussion_r193272119
--- Diff: nifi-commons/nifi-utils/pom.xml ---
@@ -40,5 +40,10 @@
<artifactId>nifi-api</artifactId>
<version>1.7.0-SNAPSHOT</version>
</dependency>
+ <dependency>
--- End diff --
There are some things to consider when using Gson over Jackson and in
general for this PR, this is related to the point I mentioned on a different PR
about where to put a "well-formed JSON" validator:
1) Performance
(https://blog.takipi.com/the-ultimate-json-library-json-simple-vs-gson-vs-jackson-vs-json/)
2) The bundle already has Jackson (such as the Mongo bundle)
3) Increased NAR size (Gson is only ~23K so minor but 84 current bundles
use nifi-utils and only 1-2 were updated to use the validator)
@zenfenan I agree that on the surface, Gson takes care of this issue
conveniently and with a lightweight footprint. However because of the reasons
above, it seems this could be problematic, and we should consider a different
approach regardless of convenience.
---
