Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2723#discussion_r193387554
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-web-utils/pom.xml ---
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+license agreements. See the NOTICE file distributed with this work for
additional
+information regarding copyright ownership. The ASF licenses this file to
+You under the Apache License, Version 2.0 (the "License"); you may not use
+this file except in compliance with the License. You may obtain a copy of
+the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+by applicable law or agreed to in writing, software distributed under the
+License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
CONDITIONS
+OF ANY KIND, either express or implied. See the License for the specific
+language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <artifactId>nifi-standard-bundle</artifactId>
+ <groupId>org.apache.nifi</groupId>
+ <version>1.7.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>nifi-standard-web-utils</artifactId>
--- End diff --
I think extracting TestServer.java was not necessary, and I'd avoid doing
this in this PR. Because:
- It makes this PR to touch many files unnecessarily in terms of its
objective.
- Having test scope dependency to `nifi-standard-processors` should be fine
to reuse TestServer.
- Even if we do extract TestServer, the module name
`nifi-standard-web-utils` will not be appropriate to contain Test utility
class. It should be named more clearly to state that this module is for test.
`nifi-mock` is a good example.
Do you have a strong motivation to do this?
---
