[
https://issues.apache.org/jira/browse/NIFI-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503624#comment-16503624
]
ASF GitHub Bot commented on NIFI-5271:
--------------------------------------
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2765
ran a full clean build w/contrib check prior to the fix for moving
ObjectMapper creation inside the validator creation. If that all checks out
via Travis-CI then I am a +1.
The L&N is now fine since Jackson is already properly accounted for in the
three impacted Nars so no further L&N changes are needed.
@MikeThomsen and @zenfenan please be very careful in all changes such
that anytime a dependency is added, removed, updated in terms of version that
all impacted Nars and all assocated L&N impacts are considered. In the
previous approach every single Nar that uses nifi-utils for StandardValidators
would require the update and not only the L&N impact but also the size impact
of having jackson libs in each but also the dependency heft of it in general.
We must be super dilligent on handling L&N so in general if you're altering
dependencies or reviewing PRs that alter dependencies keep in mind we must
account for every dependency be they direct or transitive in the appropriate
L&N. It is a lot of work.
Thanks
> Move JSON Validator to a separate package and verify license/notice
> -------------------------------------------------------------------
>
> Key: NIFI-5271
> URL: https://issues.apache.org/jira/browse/NIFI-5271
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
> Priority: Major
>
> The JSON Validator in 5261 did not get its L&N verified and it should be
> moved to a separate validator module to keep Gson from being bundled where
> it's not needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
