[ 
https://issues.apache.org/jira/browse/NIFI-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504637#comment-16504637
 ] 

ASF GitHub Bot commented on NIFI-5059:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2619#discussion_r193733115
  
    --- Diff: 
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java
 ---
    @@ -176,6 +176,8 @@ public static SchemaAccessStrategy 
getSchemaAccessStrategy(final String allowabl
                 return new 
HortonworksAttributeSchemaReferenceStrategy(schemaRegistry);
             } else if 
(allowableValue.equalsIgnoreCase(CONFLUENT_ENCODED_SCHEMA.getValue())) {
                 return new ConfluentSchemaRegistryStrategy(schemaRegistry);
    +        } else if 
(allowableValue.equalsIgnoreCase(INFER_SCHEMA.getValue())) {
    --- End diff --
    
    Since this inference only works when the content is JSON, I think this 
option should only be available when using a JSON related record reader, and 
not available in the default case. 
    
    This would be similar to how the AvroReader makes available the option for 
"Embedded Avro Schema" - 
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/AvroReader.java#L63
    



> MongoDBLookupService should be able to determine a schema or have one provided
> ------------------------------------------------------------------------------
>
>                 Key: NIFI-5059
>                 URL: https://issues.apache.org/jira/browse/NIFI-5059
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>
> MongoDBLookupService should have two schema handling modes:
>  # Where a schema is provided as a configuration parameter to be applied to 
> the Record object generated from the result document.
>  # A schema will be generated by examining the result object and building one 
> that roughly translates from BSON into the Record API.
> In both cases, the schema will be applied to the Mongo result Document object 
> that is returned if one comes back.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to