Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2619#discussion_r193739859
  
    --- Diff: 
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/JsonSchemaAccessStrategy.java
 ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.schema.access;
    +
    +import org.apache.nifi.serialization.record.RecordSchema;
    +
    +import java.io.IOException;
    +import java.util.Map;
    +
    +public interface JsonSchemaAccessStrategy extends SchemaAccessStrategy {
    --- End diff --
    
    Ok but I'm confused because I'm not seeing an actual call that uses the new 
method...
    
    The MongoLookupService does this:
    ```
    
    private RecordSchema loadSchema(Map<String, Object> coordinates, Document 
doc) {
    +        Map<String, String> variables = coordinates.entrySet().stream()
    +            .collect(Collectors.toMap(
    +                e -> e.getKey(),
    +                e -> e.getValue().toString()
    +            ));
    +        ObjectMapper mapper = new ObjectMapper();
    +        try {
    +            byte[] bytes = mapper.writeValueAsBytes(doc);
    +            return getSchema(variables, new ByteArrayInputStream(bytes), 
null);
    +        } catch (Exception ex) {
    +            return null;
    +        }
    +    }
    
    So since we are reserializing the Doc here and putting the coordinates as 
variables, I'm not seeing where we call the new method, but I may be missing it.
    ```


---

Reply via email to