[
https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508230#comment-16508230
]
ASF GitHub Bot commented on NIFI-5155:
--------------------------------------
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2773
@mattyb149 I think this makes sense but have a couple of thoughts on the PR:
- Probably should use the value set in NiFiProperties for the http/https
hostname if it is populated. This would be more consistent with the value
provided to the Cluster Coordinator and also is better for multi-homed
environments.
- If not available, I would do the
`InetAddress.getLocalHost().getHostAddress()` address only once and stash away
that value in a `final` member variable rather than performing the lookup for
each Bulletin that is created.
> Bulletins do not include IP/hostname information
> ------------------------------------------------
>
> Key: NIFI-5155
> URL: https://issues.apache.org/jira/browse/NIFI-5155
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> There is an API call on Bulletin for setNodeAddress(), which is meant to set
> the node on which a bulletin/error has occurred. The
> SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to
> the outgoing records (if available). However, the framework is not calling
> setNodeAddress() anywhere, which results in the field being missing from the
> outgoing records.
> NiFi should add the appropriate node address information to the outgoing
> bulletin information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
