[
https://issues.apache.org/jira/browse/NIFI-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511579#comment-16511579
]
ASF GitHub Bot commented on NIFI-5308:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2790
NIFI-5308: Avoid holding Template DOM Nodes in heap
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5308
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2790.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2790
----
commit 21c75ce0e2498edba59d30f8eabf29a9fcd03da3
Author: Mark Payne <markap14@...>
Date: 2018-06-13T19:37:02Z
NIFI-5308: Avoid holding Template DOM Nodes in heap
----
> Avoid holding DOM Node for templates in memory
> ----------------------------------------------
>
> Key: NIFI-5308
> URL: https://issues.apache.org/jira/browse/NIFI-5308
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.7.0
>
>
> As part of the changes made for NIFI-950, in order to improve clustering
> stability we changed the serialization of templates so that once serialized,
> we keep the DOM node in memory because it's much more efficient than
> serializing each time. However, use of the application has shown that with a
> fairly significant number of templates, the DOM nodes can lead to rather
> extensive heap utilization, causing the nodes themselves to become unstable.
> It's better to avoid this caching and just revert to the way that we
> previously were handling template serialization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
