[GitHub] nifi issue #2791: NIFI-5258 - Changed addHeader to setHeader which stops X-F...

[alopresto]

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2791
  
    I verified this in both *default* and *secured* modes against a URL that 
previously returned the double header value:
    
    ```
    hw12203:/Users/alopresto/Workspace/nifi (pr2791) alopresto
    🔓 0s @ 15:36:56 $ curl -v http://localhost:8080/nifi/
    *   Trying 127.0.0.1...
    * Connected to localhost (127.0.0.1) port 8080 (#0)
    > GET /nifi/ HTTP/1.1
    > Host: localhost:8080
    > User-Agent: curl/7.43.0
    > Accept: */*
    >
    < HTTP/1.1 200 OK
    < Date: Wed, 13 Jun 2018 22:37:12 GMT
    < X-Frame-Options: SAMEORIGIN
    < Content-Type: text/html;charset=utf-8
    < Vary: Accept-Encoding, User-Agent
    < Transfer-Encoding: chunked
    < Server: Jetty(9.4.3.v20170317)
    <
    
    
hw12203:...space/nifi/nifi-assembly/target/nifi-1.7.0-SNAPSHOT-bin/nifi-1.7.0-SNAPSHOT
 (pr2791) alopresto
    🔓 0s @ 16:10:05 $ curl -v -k --cert 
conf/CN\=cert-user_OU\=Apache_NiFi.p12:passwordpassword --cert-type P12 
https://localhost:9443/nifi/
    *   Trying 127.0.0.1...
    * Connected to localhost (127.0.0.1) port 9443 (#0)
    * Client certificate: cert-user
    * TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
    * Server certificate: nifi.nifi.apache.org
    * Server certificate: nifi-ca.local
    > GET /nifi/ HTTP/1.1
    > Host: localhost:9443
    > User-Agent: curl/7.43.0
    > Accept: */*
    >
    < HTTP/1.1 200 OK
    < Date: Wed, 13 Jun 2018 23:11:26 GMT
    < X-Frame-Options: SAMEORIGIN
    < Content-Type: text/html;charset=utf-8
    < Vary: Accept-Encoding, User-Agent
    < Transfer-Encoding: chunked
    < Server: Jetty(9.4.3.v20170317)
    < 
    
    
hw12203:...space/nifi/nifi-assembly/target/nifi-1.7.0-SNAPSHOT-bin/nifi-1.7.0-SNAPSHOT
 (pr2791) alopresto
    🔓 2s @ 16:11:28 $ curl -v -k --cert 
conf/CN\=cert-user_OU\=Apache_NiFi.p12:passwordpassword --cert-type P12 
https://localhost:9443
    * Rebuilt URL to: https://localhost:9443/
    *   Trying 127.0.0.1...
    * Connected to localhost (127.0.0.1) port 9443 (#0)
    * Client certificate: cert-user
    * TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
    * Server certificate: nifi.nifi.apache.org
    * Server certificate: nifi-ca.local
    > GET / HTTP/1.1
    > Host: localhost:9443
    > User-Agent: curl/7.43.0
    > Accept: */*
    >
    < HTTP/1.1 200 OK
    < Date: Wed, 13 Jun 2018 23:12:37 GMT
    < X-Frame-Options: SAMEORIGIN
    < Content-Type: text/html;charset=utf-8
    < Vary: Accept-Encoding, User-Agent
    < Content-Length: 1058
    < Server: Jetty(9.4.3.v20170317)
    <
    ``` 
    
    Ran `contrib-check` and all tests pass. +1, merging. 


---