[
https://issues.apache.org/jira/browse/NIFI-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512041#comment-16512041
]
ASF GitHub Bot commented on NIFI-4579:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2794
NIFI-4579: Fix ValidateRecord type coercing
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4579
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2794.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2794
----
commit e0d72610ea850415742edec22136f0fe25267918
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-06-14T06:39:17Z
NIFI-4579: Fix ValidateRecord type coercing
----
> When Strict Type Checking property is set to "false", ValidateRecord does not
> coerce fields into the correct type.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4579
> URL: https://issues.apache.org/jira/browse/NIFI-4579
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website, Extensions
> Affects Versions: 1.4.0
> Reporter: Andrew Lim
> Assignee: Koji Kawamura
> Priority: Major
>
> The description of the Strict Type Checking property for the ValidateRecord
> processor states:
> _If false, the Record will be considered valid and the field will be coerced
> into the correct type (if possible, according to the type coercion supported
> by the Record Writer)._
> In my testing I've confirmed that in this scenario, the records are
> considered valid. But, none of the record fields are coerced into the
> correct type.
> We should either correct the documentation or implement the promised coercion
> functionality.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
