[
https://issues.apache.org/jira/browse/NIFI-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513838#comment-16513838
]
ASF GitHub Bot commented on NIFI-5188:
--------------------------------------
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2696
+1 LGTM, I was able to verify that the existing aggregators are still
present, and that the sketch and histogram aggregator modules are added. Thanks
for this improvement! Merging to master
> DruidTranquilityController does not fully support Druid aggregator
> ------------------------------------------------------------------
>
> Key: NIFI-5188
> URL: https://issues.apache.org/jira/browse/NIFI-5188
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Dongkyu Hwangbo
> Priority: Major
>
> Currently DruidTranquilityController does not fully support Druid aggregator
> because of some code line hard-codeded in
> DruidTranquilityController#getAggregatorList.
> {code:java}
> ...
> if (aggregator.get("type").equalsIgnoreCase("count")) {
> aggregatorList.add(getCountAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("doublesum")) {
> aggregatorList.add(getDoubleSumAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("doublemax")) {
> aggregatorList.add(getDoubleMaxAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("doublemin")) {
> aggregatorList.add(getDoubleMinAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("longsum")) {
> aggregatorList.add(getLongSumAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("longmax")) {
> aggregatorList.add(getLongMaxAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("longmin")) {
> aggregatorList.add(getLongMinAggregator(aggregator));
> }
> ...
> {code}
> DruidTranquilityController cannot ingest other Druid aggregator not defined
> in above like cardinality, hyperUnique, thetaSketch and so on. Full
> aggregator list is in
> [here|http://druid.io/docs/0.9.2/querying/aggregations.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
