Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196931673
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseSyslog5424.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import com.github.palindromicity.syslog.NilPolicy;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.Test;
+
+public class TestParseSyslog5424 {
+ private static final String SYSLOG_LINE_ALL = "<14>1
2014-06-20T09:14:07+00:00 loggregator"
+ + " d0602076-b14a-4c55-852a-981e7afeed38 DEA MSG-01"
+ + " [exampleSDID@32473 iut=\"3\" eventSource=\"Application\"
eventID=\"1011\"]"
+ + " [exampleSDID@32480 iut=\"4\" eventSource=\"Other
Application\" eventID=\"2022\"] Removing instance";
+ private static final String SYSLOG_LINE_NILS= "<14>1
2014-06-20T09:14:07+00:00 -"
+ + " d0602076-b14a-4c55-852a-981e7afeed38 - -"
+ + " [exampleSDID@32473 iut=\"3\" eventSource=\"Application\"
eventID=\"1011\"]"
+ + " [exampleSDID@32480 iut=\"4\" eventSource=\"Other
Application\" eventID=\"2022\"] Removing instance";
+
+ @Test
+ public void testValidMessage() {
+ final TestRunner runner = TestRunners.newTestRunner(new
ParseSyslog5424());
+
runner.setProperty(ParseSyslog5424.NIL_POLICY,NilPolicy.DASH.name());
+ runner.enqueue(SYSLOG_LINE_ALL.getBytes());
+ runner.run();
+
runner.assertAllFlowFilesTransferred(ParseSyslog5424.REL_SUCCESS,1);
--- End diff --
Only version and priority must be present ( IE> cannot be the NIL '-'
character ), and therefore based on the NilPolicy by be missing etc.
I *could* check for those, but their absence would actually throw an
exception. I have a test for that specifically wrt priority
---
