[
https://issues.apache.org/jira/browse/NIFI-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522838#comment-16522838
]
ASF GitHub Bot commented on NIFI-5258:
--------------------------------------
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/2812
NIFI-5258 - Changed the way servlets are created for the documentation
webapp
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi ngough-docs-xframeoptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2812.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2812
----
commit 854dbb19c97dece6f385d1bacabba17b680ec27d
Author: thenatog <thenatog@...>
Date: 2018-06-25T17:23:28Z
NIFI-5258 - Changed the way the servlets are created for the documentation
webapp.
commit 330cccb35b43f43cabc06ba77794aefd4e9c0a41
Author: thenatog <thenatog@...>
Date: 2018-06-25T17:59:25Z
NIFI-5258 - Removed some unnecessary code.
commit 491294643c60b55abfccd377f5d9d648d666c827
Author: thenatog <thenatog@...>
Date: 2018-06-25T21:13:41Z
NIFI-5258 - Fixed imports.
----
> Improve handling of response headers for consistent application
> ---------------------------------------------------------------
>
> Key: NIFI-5258
> URL: https://issues.apache.org/jira/browse/NIFI-5258
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.6.0
> Reporter: Andy LoPresto
> Assignee: Nathan Gough
> Priority: Minor
> Labels: http, response
>
> Some response headers are not set consistently (missing or duplicated) on the
> different web contexts. Enforce consistent behavior.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
