[ 
https://issues.apache.org/jira/browse/MINIFICPP-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524531#comment-16524531
 ] 

ASF GitHub Bot commented on MINIFICPP-427:
------------------------------------------

Github user dtrodrigues commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198359374
  
    --- Diff: extensions/librdkafka/PublishKafka.cpp ---
    @@ -262,7 +269,7 @@ void PublishKafka::onTrigger(const 
std::shared_ptr<core::ProcessContext> &contex
       if (flowFile->getAttribute(KAFKA_KEY_ATTRIBUTE, value))
         kafkaKey = value;
     
    -  PublishKafka::ReadCallback callback(flowFile->getSize(), max_seg_size_, 
kafkaKey, rkt_);
    +  PublishKafka::ReadCallback callback(flowFile->getSize(), max_seg_size_, 
kafkaKey, rkt_, rk_, flowFile, attributeNameRegex);
    --- End diff --
    
    Now that we're sending the flowFile so we have access to the attributes, we 
don't need to send the size by itself anymore. I'll update this.


> Add headers support in PublishKafka
> -----------------------------------
>
>                 Key: MINIFICPP-427
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-427
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Pierre Villard
>            Assignee: Dustin Rodrigues
>            Priority: Major
>
> Would be nice to add headers support in PublishKafka (assuming Kafka 0.11+) 
> in order to preserve attributes of the flow files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to