[
https://issues.apache.org/jira/browse/NIFI-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527730#comment-16527730
]
ASF GitHub Bot commented on NIFI-5339:
--------------------------------------
GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/2824
NIFI-5339 - Better Time Tracking for ExecuteSQL Durations
@pvillard31 I forgot to add in the `WritesAttribute` annotations for the
new attributes on NIFI-5339.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-5339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2824
----
commit 8c3775e09ea0cacab2cc16f7a1b2baa92095d8a3
Author: patricker <patricker@...>
Date: 2018-06-26T19:27:11Z
NIFI-5339
commit 1e41e1521c881fd12752734686d86820bf7defca
Author: patricker <patricker@...>
Date: 2018-06-29T14:33:51Z
NIFI-5339
----
> Better Time Tracking for ExecuteSQL Durations
> ---------------------------------------------
>
> Key: NIFI-5339
> URL: https://issues.apache.org/jira/browse/NIFI-5339
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Peter Wicks
> Assignee: Peter Wicks
> Priority: Minor
> Fix For: 1.8.0
>
>
> ExecuteSQL uses an attribute, `executesql.query.duration`, to track how long
> query execution and fetch took.
> For multiple result set queries this is a cumulative/running total, and is
> not specific to each query.
> Also, there is no separation between query execution and fetch times.
> Updates:
> * Add a dedicated property `executesql.query.executiontime` to track the
> base query execution time.
> * Add a dedicated property 'executesql.query.fetchtime` to track the per
> resultset fetch time.
> * Update the existing `executesql.query.duration` to be the sum of the other
> two times.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
