[
https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529751#comment-16529751
]
ASF GitHub Bot commented on NIFI-4889:
--------------------------------------
GitHub user Trojan295 opened a pull request:
https://github.com/apache/nifi/pull/2830
NIFI-4889: Logout not working properly with OIDC
- Redirect user agent to end session endpoint on the OIDC provider
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Trojan295/nifi NIFI-4889
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2830.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2830
----
commit fba6497948d12a272b4a593e8eb8c469badbfdf5
Author: Damian Czaja <damian.czaja@...>
Date: 2018-07-02T11:35:03Z
NIFI-4889: Logout not working properly with OIDC
- Redirect user agent to end session endpoint on the OIDC provider
----
> Logout not working properly with OIDC
> -------------------------------------
>
> Key: NIFI-4889
> URL: https://issues.apache.org/jira/browse/NIFI-4889
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
> Affects Versions: 1.5.0
> Environment: Browser: Chrome / Firefox
> Configuration of NiFi:
> - SSL certificate for the server (no client auth)
> - OIDC configuration including end_session_endpoint (see the link
> https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration)
> Reporter: Federico Michele Facca
> Priority: Critical
>
> Click on logout, i would expect to logout and getting redirect to the auth
> page. But given that the session is not closed on the oauth provider, i get
> logged in again.
> I suppose the solution would be to invoke the end_session_endpoint provided
> in the openid discovery configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
