[
https://issues.apache.org/jira/browse/MINIFICPP-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529783#comment-16529783
]
ASF GitHub Bot commented on MINIFICPP-515:
------------------------------------------
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/359
@achristianson I feel like there is something I'm missing because there had
to have been a reason c_str() existed. On Friday I took another look and
couldn't statically determine why that was one. So I'm inclined to merge this
since there is no test or comment that alludes to why the newly constructed
string was formulated.
> Implement emplace_back for values in Property class
> ---------------------------------------------------
>
> Key: MINIFICPP-515
> URL: https://issues.apache.org/jira/browse/MINIFICPP-515
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> We're calling push_back instead of emplace_back, as well as unnecessarily
> rebuilding strings from c_string() values.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
