[
https://issues.apache.org/jira/browse/NIFI-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529849#comment-16529849
]
ASF GitHub Bot commented on NIFI-5361:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2831
NIFI-5361: When submitting many processors to start, calculate the 't…
…imeout timestamp' immediately before calling @OnScheduled method, after
the task has been scheduled to run, instead of before the task has a chance to
run.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5361
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2831
----
commit 28f76e1569f695a94a801379b02a991136b80cc5
Author: Mark Payne <markap14@...>
Date: 2018-06-29T13:25:57Z
NIFI-5361: When submitting many processors to start, calculate the 'timeout
timestamp' immediately before calling @OnScheduled method, after the task has
been scheduled to run, instead of before the task has a chance to run.
----
> Upon restart of NiFi, some processors show Active Threads but never actually
> run
> --------------------------------------------------------------------------------
>
> Key: NIFI-5361
> URL: https://issues.apache.org/jira/browse/NIFI-5361
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Critical
>
> Upon restart, if there are a large number of processors that take a long time
> to start up (i.e., their {{@OnScheduled}} methods take a long time to
> complete), then other processors may also timeout while waiting for their
> {{@OnScheduled}} method to complete. It looks like this is due to the fact
> that when we schedule many processors we determine the 'timeout timestamp'
> before submitting the background task to call {{@OnScheduled}}. As a result,
> if several processors don't finish or take a long time to finish, then other
> processors may just sit, waiting for their chance to have {{@OnScheduled}}
> called and eventually timeout before they even have a chance to invoke the
> method.
> When this happens, the result is that the Runnable to call {{@OnScheduled}}
> never is called before the corresponding {{Future}} is canceled. So the
> Processor is never scheduled. However, its Active Thread count has already
> been incremented. So it appears as if the Processor has an Active Thread but
> it will never make progress.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
