[
https://issues.apache.org/jira/browse/NIFI-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530398#comment-16530398
]
ASF GitHub Bot commented on NIFI-5147:
--------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2836
NIFI-5147 Calculate hash attribute redux
[#2802](https://github.com/apache/nifi/pull/2802)
The prior PR landed, but was reverted for further review. I cannot
re-open, so I'm creating a new PR.
Please reference the comments in the old pr.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi calculate-hash-attribute
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2836
----
commit 75b70ccfc80d5e3529a7beeb575f3bc3b3cc548b
Author: Otto Fowler <ottobackwards@...>
Date: 2018-06-18T15:00:38Z
NIFI-5147 Add CalculateAttributeHash processor
commit da03c6749e2482a57030a22389a2b9a1606a16fd
Author: Otto Fowler <ottobackwards@...>
Date: 2018-06-26T18:51:06Z
add warning and recommendation link
commit 6951040beaa63afa21a6a5b2f45139259a5e604d
Author: Otto Fowler <ottobackwards@...>
Date: 2018-07-01T16:18:08Z
per review
- added properties to control behavior when attributes that are configured
are partially or completely missing
- set charset with a property
- added tests
commit 2af8be80b89c67fa113f37a643893fbb3d8a6520
Author: Otto Fowler <ottobackwards@...>
Date: 2018-07-01T16:25:24Z
fix assert parameter order
----
> Improve HashAttribute processor
> -------------------------------
>
> Key: NIFI-5147
> URL: https://issues.apache.org/jira/browse/NIFI-5147
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Reporter: Andy LoPresto
> Assignee: Otto Fowler
> Priority: Major
> Labels: hash, security
> Fix For: 1.8.0
>
>
> The {{HashAttribute}} processor currently has surprising behavior. Barring
> familiarity with the processor, a user would expect {{HashAttribute}} to
> generate a hash value over one or more attributes. Instead, the processor as
> it is implemented "groups" incoming flowfiles into groups based on regular
> expressions which match attribute values, and then generates a
> (non-configurable) MD5 hash over the concatenation of the matching attribute
> keys and values.
> In addition:
> * the processor throws an error and routes to failure any incoming flowfile
> which does not have all attributes specified in the processor
> * the use of MD5 is vastly deprecated
> * no other hash algorithms are available
> I am unaware of community use of this processor, but I do not want to break
> backward compatibility. I propose the following steps:
> * Implement a new {{CalculateAttributeHash}} processor (awkward name, but
> this processor already has the desired name)
> ** This processor will perform the "standard" use case -- identify an
> attribute, calculate the specified hash over the value, and write it to an
> output attribute
> ** This processor will have a required property descriptor allowing a
> dropdown menu of valid hash algorithms
> ** This processor will accept arbitrary dynamic properties identifying the
> attributes to be hashed as a key, and the resulting attribute name as a value
> ** Example: I want to generate a SHA-512 hash on the attribute {{username}},
> and a flowfile enters the processor with {{username}} value {{alopresto}}. I
> configure {{algorithm}} with {{SHA-512}} and add a dynamic property
> {{username}} -- {{username_SHA512}}. The resulting flowfile will have
> attribute {{username_SHA512}} with value
> {{739b4f6722fb5de20125751c7a1a358b2a7eb8f07e530e4bf18561fbff93234908aa9d2577770c876bca9ede5ba784d5ce6081dbbdfe5ddd446678f223b8d632}}
> * Improve the documentation of this processor to explain the goal/expected
> use case (?)
> * Link in processor documentation to new processor for standard use cases
> * Remove the error alert when an incoming flowfile does not contain all
> expected attributes. I propose changing the severity to INFO and still
> routing to failure
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
