[
https://issues.apache.org/jira/browse/NIFI-5374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531925#comment-16531925
]
ASF GitHub Bot commented on NIFI-5374:
--------------------------------------
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/2840
NIFI-5374 - Suppress stacktrace being returned to remote client when using
NiFi REST API
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi NIFI-5374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2840
----
commit eafe1bbf05c367bca30ca4fa334ccbaa4d3eb0fa
Author: thenatog <thenatog@...>
Date: 2018-07-03T18:21:03Z
NIFI-5374 - Added ExceptionFilter which catches RequestRejectedException
thrown in the nifi-api Jersey code. These exceptions were not caught by the
Jetty error-page configuration because they're thrown before the endpoint/Jetty
routing is hit.
NIFI-5374 - Added integration test for checking the ExceptionFilter catches
malicious string exceptions.
----
> Suppress stacktrace being returned to remote client when using NiFi REST API
> ----------------------------------------------------------------------------
>
> Key: NIFI-5374
> URL: https://issues.apache.org/jira/browse/NIFI-5374
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.7.0
> Reporter: Nathan Gough
> Assignee: Nathan Gough
> Priority: Minor
> Labels: filter, stacktrace, suppress
> Attachments: image001.png
>
>
> When a remote user attempts to use an endpoint with a malicious string, Jetty
> will return a full stacktrace of the error. This provides the remote user
> with excess information that can be used when attempting to manipulate a
> system.
> !image001.png!
> This stacktrace should be logged only to the nifi-app.log and the stacktrace
> suppressed before returning a 500 error to the user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
