Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2840
  
    Thanks @thenatog. I reviewed this and it looks good. While initially I 
tried to run integration tests for the entire project, there is a failing 
integration test 
`StandardControllerServiceProviderIT.testConcurrencyWithEnablingReferencingServicesGraph:96->testEnableReferencingServicesGraph`
 which I opened a ticket for 
[NIFI-5375](https://issues.apache.org/jira/browse/NIFI-5375). Building normally 
and then running integration tests on just this module is successful. I made 
some minor fixes for code style (see [commit 
8792f90](https://github.com/alopresto/nifi/commit/12503047009bac80da4858b8fc99da35a8792f90)
 on branch NIFI-5374-PR-2840). 
    
    I verified against a running instance as well, and will merge this PR. 


---

Reply via email to