[ https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533652#comment-16533652 ]
ASF GitHub Bot commented on NIFI-5318: -------------------------------------- GitHub user peter-gergely-horvath opened a pull request: https://github.com/apache/nifi/pull/2844 NIFI-5318 Implement NiFi test harness: initial commit of nifi-test Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? Could not run this, I have test failures in my environment, that are unrelated to the code changes: ``` [INFO] Running org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 61.062 s <<< FAILURE! - in org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex [ERROR] testUnauthorizedEventsGetPlaceholdersForExpandChildren(org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex) Time elapsed: 60.014 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 60000 milliseconds at org.apache.nifi.provenance.index.lucene.TestLuceneEventIndex.testUnauthorizedEventsGetPlaceholdersForExpandChildren(TestLuceneEventIndex.java:206) ``` - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/peter-gergely-horvath/nifi master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2844.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2844 ---- commit 57a10ada3c00be30a39bd892fa634306626e89b2 Author: Peter G. Horvath <peter.gergely.horvath@...> Date: 2018-07-05T13:28:20Z NIFI-5318 Implement NiFi test harness: initial commit of nifi-test ---- > Implement NiFi test harness > --------------------------- > > Key: NIFI-5318 > URL: https://issues.apache.org/jira/browse/NIFI-5318 > Project: Apache NiFi > Issue Type: New Feature > Reporter: Peter Horvath > Priority: Major > > Currently, it is not really possible to automatically test the behaviour of a > specific NiFi flow and make unit test type asserts if it works as expected. > For example, if the expected behaviour of a NiFi flow is that a file placed > to a specific directory will trigger some operation after which some output > file will appear at another directory, once currently can only do one thing: > test the NiFi flow manually. > Manual testing is especially hard to manage if a NiFi flow is being actively > developed: any change to a complex, existing NiFi flow might require a lot of > manual testing just to ensure there are no regressions introduced. > Some kind of Java API that allows managing a NiFi instance and manipulating > flow deployments like for example, [Codehaus > Cargo|]https://codehaus-cargo.github.io/] would be of great help. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)