[
https://issues.apache.org/jira/browse/NIFI-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535212#comment-16535212
]
ASF GitHub Bot commented on NIFI-5386:
--------------------------------------
GitHub user HorizonNet opened a pull request:
https://github.com/apache/nifi/pull/2851
NIFI-5386 Removed redundant dependencies from nifi-redis-extensions
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder? Fails at
`nifi-standard-processors`.
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ultratendency/nifi NIFI-5386
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2851.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2851
----
commit 4097f45e4132d7d43705375b464c366f806933f1
Author: Jan Hentschel <jan.hentschel@...>
Date: 2018-07-06T18:35:11Z
NIFI-5386 Removed redundant dependencies from nifi-redis-extensions
----
> Remove redundant dependencies from nifi-redis-extensions
> --------------------------------------------------------
>
> Key: NIFI-5386
> URL: https://issues.apache.org/jira/browse/NIFI-5386
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Jan Hentschel
> Priority: Trivial
>
> The module {{nifi-redis-extensions}} defines the dependencies
> {{slf4j-simple}} and {{junit}}, which are already defined in the root POM and
> can be removed safely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
