[ 
https://issues.apache.org/jira/browse/NIFI-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537378#comment-16537378
 ] 

ASF GitHub Bot commented on NIFI-5382:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2853#discussion_r201105301
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractRecordProcessor.java
 ---
    @@ -64,6 +64,15 @@
             .required(true)
             .build();
     
    +    static final PropertyDescriptor DROP_EMPTY_FILES = new 
PropertyDescriptor.Builder()
    +        .name("drop-empty-files")
    +        .displayName("Drop Files With No Records")
    --- End diff --
    
    I agree with Joe's point, whether he means it makes sense to have such a 
property to filter out 0 record files, or that this new property should be 
consistent in naming and behavior with the one added to QueryRecord. Right now 
this new property has inverse naming/behavior from the QueryRecord one, should 
we use a copy of the QueryRecord one here instead?


> ConvertRecord 1.7.0 - Creates emtpy Flow File
> ---------------------------------------------
>
>                 Key: NIFI-5382
>                 URL: https://issues.apache.org/jira/browse/NIFI-5382
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 1.7.0
>            Reporter: Stefan Goldener
>            Assignee: Peter Wicks
>            Priority: Minor
>         Attachments: ConvertRecordBUG.xml
>
>
> The Nifi ConvertRecord Processor does create an empty flow file in case the 
> input is a CSV with Header but no content. If no content is available the 
> flow file should be ignored or at least there should be an option to ignore 
> empty files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to