GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/2868
NIFI-5312 QueryDatabaseTable updates state when an SQLException is thâ¦
â¦rown
If an exception is thrown mid ResultSet processing, the state of
QueryDatabaseTable could very easily be updated with the way the code runs now.
I added in a flag that helps us determine if we should update the
processors state with new max values or not.
Could not find a good hook for unit testing, please provide suggestions if
you have them.
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-5312
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2868.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2868
----
commit b23bbf6466c9d957d57036f60e56bf82797be187
Author: patricker <patricker@...>
Date: 2018-07-09T20:14:57Z
NIFI-5312 QueryDatabaseTable updates state when an SQLException is thrown
----
---
