[
https://issues.apache.org/jira/browse/NIFI-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538776#comment-16538776
]
ASF GitHub Bot commented on NIFI-5368:
--------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2873
> Referenced Controller Services not being validated in Mock Framework
> --------------------------------------------------------------------
>
> Key: NIFI-5368
> URL: https://issues.apache.org/jira/browse/NIFI-5368
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Tools and Build
> Affects Versions: 1.7.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Blocker
> Fix For: 1.8.0
>
>
> During the refactoring for NIFI-950, the validation of of referenced
> Controller Services moved from AbstractConfigurableComponent to
> AbstractComponentNode. While this works fine for NiFi's lifecycle, it does
> cause problems with the Mock Framework. Because the Mock Framework does not
> create an AbstractComponentNode, only the AbstractConfigurableComponent, and
> validates that component directly, referenced Controller Services are not
> validated. Additionally, they are not (and never have been) validated when
> enabled.
> We should update the Mock Framework such that when
> {{TestRunner.enableControllerService(ControllerService)}} is called, we first
> validate the Controller Service before enabling it.
> Additionally, in the {{AbstractConfigurableComponent}}, or in the Mock
> Framework itself, verify that all referenced services are in fact enabled
> when validating the component.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
