[
https://issues.apache.org/jira/browse/NIFI-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538926#comment-16538926
]
ASF GitHub Bot commented on NIFI-5312:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2868#discussion_r201416057
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
---
@@ -433,7 +434,7 @@ public void onTrigger(final ProcessContext context,
final ProcessSessionFactory
} finally {
session.commit();
try {
- // Update the state
+ // Check if we should, and then update the state
--- End diff --
Looks like maybe too much was removed? The comment is still changed but the
AtomicBoolean is gone, also I couldn't see a reference to where
rollbackStateChanges() is called.
> QueryDatabaseTable updates state when an SQLException is thrown
> ---------------------------------------------------------------
>
> Key: NIFI-5312
> URL: https://issues.apache.org/jira/browse/NIFI-5312
> Project: Apache NiFi
> Issue Type: Bug
> Environment: Ubuntu 16.04
> Apache NiFi 1.5.0, 1.6.0
> IBM DB2 for Linux, UNIX and Windows 10.5.0.7, 10.5.0.8 (1)
> IBM Data Server Driver for JDBC and SQLJ, JDBC 4.0 Driver (db2jcc4.jar)
> 4.19.26 / v10.5 FP6, 4.19.72 / v10.5 FP9 (2)
> Notes:
> (1) SELECT * FROM SYSIBMADM.ENV_INST_INFO
> (2) java -cp ./db2jcc4.jar com.ibm.db2.jcc.DB2Jcc -version
> Reporter: Marcio Sugar
> Assignee: Peter Wicks
> Priority: Major
>
> I noticed that when an SQLException is thrown, at least in the situation
> described by NIFI-4926, QueryDatabaseTable still updates the state of the
> Maximum-value Columns. It means that when something goes wrong, a potentially
> big number of rows will be skipped pretty much silently. (Well, it will
> appear in the Bulletin Board, but when the message disappears from the
> Bulletin Board there will be no indication of the problem left. The processor
> has no "terminate relationship" other than "Success".)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
