[
https://issues.apache.org/jira/browse/NIFI-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539061#comment-16539061
]
ASF GitHub Bot commented on NIFI-5070:
--------------------------------------
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/2629
I like the unit tests, but what about moving your check?
If you created a `catch` block at the end of the existing `try` block in
`convertToAvroStream` it would probably simplify the flow a lot. Keep the same
`isClosed` check... maybe?
Also, this seems to specifically be for Phoenix. With the fix as is, I
don't know if it's possible to tell the difference between a database going
offline for maintenance mid resultset read and a Phoenix end of resulset
closure.
Could we check the Exception Message for the specific Phoenix error code so
we don't block visibility to legitimate early connection closure errors?
> java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is closed
> --------------------------------------------------------------
>
> Key: NIFI-5070
> URL: https://issues.apache.org/jira/browse/NIFI-5070
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Gardella Juan Pablo
> Priority: Major
>
> Discovered during NIFI-5049. According [ResultSet.next()
> javadoc|https://docs.oracle.com/javase/8/docs/api/java/sql/ResultSet.html#next%E2%80%93]:
> _When a call to the {{next}} method returns {{false}}, the cursor is
> positioned after the last row. Any invocation of a {{ResultSet}} method which
> requires a current row will result in a {{SQLException}} being thrown. If the
> result set type is {{TYPE_FORWARD_ONLY}}, it is vendor specified whether
> their JDBC driver implementation will return {{false}} or throw an
> {{SQLException}} on a subsequent call to {{next}}._
> With Phoenix Database and QueryDatabaseTable the exception
> {{java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is closed}} is raised.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
