[
https://issues.apache.org/jira/browse/NIFI-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543217#comment-16543217
]
ASF GitHub Bot commented on NIFI-5415:
--------------------------------------
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2883
+1 LGTM, ran with and without the change, verified the test was still being
run as a unit test without the change, and doesn't run as a unit test with the
change. Thanks for the fix! Merging to master
> Renamed ListenSyslogGroovyTest to ITListenSyslogGroovy
> ------------------------------------------------------
>
> Key: NIFI-5415
> URL: https://issues.apache.org/jira/browse/NIFI-5415
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.7.0
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Priority: Blocker
> Labels: groovy, integration-test, maven, syslog, test
> Fix For: 1.8.0, 1.7.1
>
>
> [~joewitt] made an effort to move inconsistent and network/timing-dependent
> unit tests to integration tests via NIFI-4659, NIFI-4660, NIFI-4662, and
> NIFI-4664.
> This file was renamed (from {{ListenSyslogGroovyTest.groovy}} to
> {{ITListenSyslogGroovy.groovy}}) but the class name inside was not changed. I
> believe the maven filter is on the class name, not the file name, because
> this test still runs in normal builds. It breaks inconsistently on my
> machine, so I renamed the class to ensure it is not run as part of the usual
> unit test battery. This is required for 1.7.1 to be released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
