[ 
https://issues.apache.org/jira/browse/MINIFICPP-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543329#comment-16543329
 ] 

ASF GitHub Bot commented on MINIFICPP-556:
------------------------------------------

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/371

    MINIFICPP-556 Added initial snapcraft build

    This wouldn't have been possible without the help of Jeremy Dyer.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-556

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #371
    
----
commit 4c5481aa0c44cf08786326407598659b9f3576c7
Author: Andrew I. Christianson <andy@...>
Date:   2018-07-13T15:17:37Z

    MINIFICPP-556 Added initial snapcraft build

----


> Create snap build
> -----------------
>
>                 Key: MINIFICPP-556
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-556
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Package nifi-minifi-cpp into a snap package for easy distribution to users 
> who use snap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to