[
https://issues.apache.org/jira/browse/NIFI-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543414#comment-16543414
]
ASF GitHub Bot commented on NIFI-5427:
--------------------------------------
GitHub user gresockj opened a pull request:
https://github.com/apache/nifi/pull/2890
NIFI-5427: Updating ScrollElasticsearchHttp to use POST, supporting ES6
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gresockj/nifi NIFI-5427
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2890.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2890
----
commit 2b15a7ac2e91b8bf6d922cb3c7e9eb682bc7b3ff
Author: Joe Gresock <joseph.gresock@...>
Date: 2018-07-13T16:29:45Z
NIFI-5427: Updating ScrollElasticsearchHttp to use POST, supporting ES6
----
> ScrollElasticsearchHttp breaks with Elasticsearch 6
> ---------------------------------------------------
>
> Key: NIFI-5427
> URL: https://issues.apache.org/jira/browse/NIFI-5427
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.4.0, 1.5.0, 1.6.0, 1.7.0
> Reporter: Joseph Gresock
> Assignee: Joseph Gresock
> Priority: Minor
>
> The Elasticsearch 6 Scroll API uses scroll IDs that are nearly 10,000
> characters long. Since the ScrollElasticsearchHttp processor uses a GET
> request for scrolling, this breaks the processor after the first scroll call.
>
> The solution is fairly simple: use a POST instead of a GET for the scroll
> calls. This is backwards compatible down to Elasticsearch 2.X.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
