[
https://issues.apache.org/jira/browse/MINIFICPP-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545582#comment-16545582
]
ASF GitHub Bot commented on MINIFICPP-557:
------------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/372
MINIFICPP-557: Previously the empty flag was not a necessary check as…
… we didn't
have the case where empty ValueNodes could or should occur ( and these were
dealt with elsewhere)
but recent changes have made this a new requirement thus we can add the
empty check
for validation of lists.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-557
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #372
----
commit 15ab090b3148456ca5e52aa1b79de1df5cf8badc
Author: Marc Parisi <phrocker@...>
Date: 2018-07-16T18:22:24Z
MINIFICPP-557: Previously the empty flag was not a necessary check as we
didn't
have the case where empty ValueNodes could or should occur ( and these were
dealt with elsewhere)
but recent changes have made this a new requirement thus we can add the
empty check
for validation of lists.
----
> Segfault when including C2 AgentInformation in Alpine
> -----------------------------------------------------
>
> Key: MINIFICPP-557
> URL: https://issues.apache.org/jira/browse/MINIFICPP-557
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Aldrin Piri
> Assignee: marco polo
> Priority: Major
> Attachments: minifi-app.log
>
>
> When running an instance with AgentInformation of one of the
> nifi.c2.root.classes, the instance fails to startup with a segfault.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
