[
https://issues.apache.org/jira/browse/NIFI-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545623#comment-16545623
]
ASF GitHub Bot commented on NIFI-4407:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2898
NIFI-4407: Updated Expression Language Guide to provide details about…
… how escaping $ is accomplished, and when the $ character should and
should not be escaped. Fixed bug in the Query compiler that mistakenly would
blindly replace 484 with $ even when the 484 did not precede an Expression.
Added additional test cases.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4407
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2898.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2898
----
commit 8a9ff6884253b3294598772fad60347605257b0d
Author: Mark Payne <markap14@...>
Date: 2018-07-16T17:27:46Z
NIFI-4407: Updated Expression Language Guide to provide details about how
escaping $ is accomplished, and when the $ character should and should not be
escaped. Fixed bug in the Query compiler that mistakenly would blindly replace
484 with $ even when the 484 did not precede an Expression. Added additional
test cases.
----
> Non-EL statement processed as expression language
> -------------------------------------------------
>
> Key: NIFI-4407
> URL: https://issues.apache.org/jira/browse/NIFI-4407
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.1.1, 1.0.1, 1.3.0
> Reporter: Pierre Villard
> Priority: Critical
>
> If you take a GFF with custom text: {{test$$foo}}
> The generated text will be: {{test$foo}}
> The property supports expression language and one $ is removed during the EL
> evaluation step. This can be an issue if a user wants to use a value
> containing to consecutive $$ (such as in password fields).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
