[
https://issues.apache.org/jira/browse/NIFI-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547593#comment-16547593
]
ASF GitHub Bot commented on NIFI-5438:
--------------------------------------
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2905
NIFI-5438 volume support for the NiFi docker containers
Create all volume directories for chowning properly, then create proper
volumes for persistence. Notes:
* Create conf instead of conf/templates since it will be created
automatically.
* Create database_repository instead of data, since that is the default
configuration.
* Create state volume used to store local state by default.
`mvn integration-test -P docker` ran fine from the `nifi-docker` folder
against both modules
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pepov/nifi NIFI-5438
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2905
----
commit 6dbfb7206c5cb9361e015ae74734dd6fedbe0a7c
Author: pepov <peterwilcsinszky@...>
Date: 2018-07-18T08:46:09Z
NIFI-5438 create all volume directories for chowning properly, then create
proper volumes for persistence. Notes: create conf instead of conf/templates
since it will be created automatically. Create database_repository instead of
data, since that is the default configuration. Create state volume used to
store local state by default.
----
> Declare volumes for the NiFi docker container for persistence by default
> ------------------------------------------------------------------------
>
> Key: NIFI-5438
> URL: https://issues.apache.org/jira/browse/NIFI-5438
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
> Affects Versions: 1.8.0
> Reporter: Peter Wilcsinszky
> Assignee: Peter Wilcsinszky
> Priority: Major
> Fix For: 1.8.0
>
>
> Volume declarations are missing from the NiFi Dockerfiles.
> *Without* that all data get lost after removing the container when there was
> no explicit volume declarations defined.
> *With* volume declarations all the data on the declared volumes will get
> persisted on the host without any explicit volume declarations required by
> the user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
