[ 
https://issues.apache.org/jira/browse/NIFI-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547877#comment-16547877
 ] 

ASF GitHub Bot commented on NIFI-4535:
--------------------------------------

Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2899#discussion_r203389775
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas.js
 ---
    @@ -167,12 +167,14 @@
                 
nfNgBridge.injector.get('breadcrumbsCtrl').resetScrollPosition();
     
                 // set page title to the name of the root processor group
    -            var rootBreadcrumb = breadcrumb;
    -            while(rootBreadcrumb.parentBreadcrumb != null) {
    -                rootBreadcrumb = rootBreadcrumb.parentBreadcrumb
    -            }
    +            if (breadcrumb.permissions.canRead) {
    +                var rootBreadcrumb = breadcrumb;
    +                while(rootBreadcrumb.parentBreadcrumb != null) {
    +                    rootBreadcrumb = rootBreadcrumb.parentBreadcrumb
    +                }
     
    -            document.title = rootBreadcrumb.breadcrumb.name;
    +                document.title = rootBreadcrumb.breadcrumb.name;
    --- End diff --
    
    I really appreciate your deep understanding of these more corner case 
security issues!
    I'm thinking on it, will hope to have it updated Friday.


> Set the Page Title to the name of the Root Process Group
> --------------------------------------------------------
>
>                 Key: NIFI-4535
>                 URL: https://issues.apache.org/jira/browse/NIFI-4535
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> NiFi's UI has a hard coded page title of NiFi. I have many servers and it's 
> hard to keep track of the tabs in Chrome.
> Please change the Title of the page so it matches the name of the Root 
> processor group. This way I can name the root group by server/instance, and 
> easily identify the right tab/window.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to