[ 
https://issues.apache.org/jira/browse/NIFI-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548046#comment-16548046
 ] 

ASF GitHub Bot commented on NIFI-3964:
--------------------------------------

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/1925
  
    @ottobackwards - you're completely right and by rebasing the PR, I missed 
something.
    Instead of using
    ````java
    grokCompiler.register(String,String);
    ````
    I should use
    ````java
    grokCompiler.register(Map<String,String>);
    ````
    That would solve the issue you're mentioning, right?
    
    The reasoning behind this PR is to remove the need of a file (deploying 
files on every node of a NiFi cluster can be annoying... and by using a 
controller service, this can be part of the flow development lifecycle since it 
can be saved in the NiFi Registry).
    
    What do you think?


> Grok processors - Allow custom patterns without contiguration file
> ------------------------------------------------------------------
>
>                 Key: NIFI-3964
>                 URL: https://issues.apache.org/jira/browse/NIFI-3964
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Trivial
>
> When using a lot of grok processors with different teams and use cases, it 
> would be useful to provide a way of customizing the Grok patterns without the 
> need of deploying files over the nodes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to