[
https://issues.apache.org/jira/browse/MINIFICPP-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550823#comment-16550823
]
ASF GitHub Bot commented on MINIFICPP-555:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/377
MINIFICPP-555 Pass through CMAKE args to external projects so that ex…
…ternal builds are consistent with main build
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-555
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 72ed3f347ce289e6d207204029b1112c559444e4
Author: Andrew I. Christianson <andy@...>
Date: 2018-07-19T14:35:59Z
MINIFICPP-555 Pass through CMAKE args to external projects so that external
builds are consistent with main build
----
> Pass through CMake args from build environment to external projects
> -------------------------------------------------------------------
>
> Key: MINIFICPP-555
> URL: https://issues.apache.org/jira/browse/MINIFICPP-555
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> When the build environment is customized, and especially in cross-compilation
> build environments, many CMake env vars are set which need to be, but are not
> by default, passed to external project builds. Vars include:
>
> {code:java}
> set(PASSTHROUGH_CMAKE_ARGS -DANDROID_ABI=${ANDROID_ABI}
> -DANDROID_PLATFORM=${ANDROID_PLATFORM}
> -DANDROID_STL=${ANDROID_STL}
> -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
> -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
> -DANDROID_NDK=${ANDROID_NDK}
> -DCMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}
> -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
> -DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
> -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
> -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
> -DCMAKE_FIND_ROOT_PATH=${CMAKE_FIND_ROOT_PATH}
> -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=${CMAKE_FIND_ROOT_PATH_MODE_PROGRAM}
> -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=${CMAKE_FIND_ROOT_PATH_MODE_LIBRARY}
> -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=${CMAKE_FIND_ROOT_PATH_MODE_INCLUDE}
> -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
> -G${CMAKE_GENERATOR})
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
