[
https://issues.apache.org/jira/browse/NIFI-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554269#comment-16554269
]
ASF GitHub Bot commented on NIFI-5388:
--------------------------------------
GitHub user snagafritz opened a pull request:
https://github.com/apache/nifi/pull/2915
NIFI-5388: enabled EL support for dynamic properties of Kafka 1.0 processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
```
Started writing unit tests but it seemed trivial validating that the
properties have EL support enabled. I will attach a video to the JIRA ticket of
me verifying expected behavior for the Kafka consumer.
```
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Snagajob/nifi NIFI-5388
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2915
----
commit 76707086dfef73e2ee8e2ea9dd9f6d9c725b96be
Author: Corey Fritz <corey.fritz@...>
Date: 2018-07-17T01:06:01Z
NIFI-5388: enabled EL support for dynamic properties of Kafka 1.0 processors
----
> Enable EL support for dynamic properties of Kafka processors
> ------------------------------------------------------------
>
> Key: NIFI-5388
> URL: https://issues.apache.org/jira/browse/NIFI-5388
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.7.0
> Reporter: Corey Fritz
> Priority: Minor
> Labels: kafka
>
> We have a flow committed to a NiFi Registry that includes a Kafka consumer,
> and ideally the processor configuration would include some dynamic consumer
> properties where the values would differ depending on which environment the
> flow is deployed to. Unfortunately, dynamic properties in the Kafka
> processors do not currently support EL, which would allow us to use
> environment variables to pass in those environment-specific values. So I'm
> proposing EL support be added to the dynamic properties of all Kafka
> processors.
> I am planning on tackling this ticket myself, unless someone thinks this is a
> bad idea for some reason.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
