[
https://issues.apache.org/jira/browse/MINIFICPP-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554296#comment-16554296
]
ASF GitHub Bot commented on MINIFICPP-574:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/380
MINIFICPP-574 Include required cstring library
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-574
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
----
> FileUtils.h:83:35: error: ‘strcmp’ was not declared in this scope
> -----------------------------------------------------------------
>
> Key: MINIFICPP-574
> URL: https://issues.apache.org/jira/browse/MINIFICPP-574
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> Getting compile error:
>
> {code:java}
> In file included from
> /home/achristianson/workspace/nifi-minifi-cpp/extensions/rocksdb-repos/FlowFileRepository.h:21:0,
> from
> /home/achristianson/workspace/nifi-minifi-cpp/extensions/rocksdb-repos/FlowFileRepository.cpp:18:
> /home/achristianson/workspace/nifi-minifi-cpp/extensions/rocksdb-repos/../../libminifi/include/utils/file/FileUtils.h:
> In static member function ‘static int64_t
> org::apache::nifi::minifi::utils::file::FileUtils::delete_dir(const string&,
> bool)’:
> /home/achristianson/workspace/nifi-minifi-cpp/extensions/rocksdb-repos/../../libminifi/include/utils/file/FileUtils.h:83:35:
> error: ‘strcmp’ was not declared in this scope
> if (!strcmp(p->d_name, ".") || !strcmp(p->d_name, "..")) {
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
