[ 
https://issues.apache.org/jira/browse/NIFI-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560208#comment-16560208
 ] 

ASF GitHub Bot commented on NIFI-5469:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2922#discussion_r205882343
  
    --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
    @@ -2876,40 +2980,40 @@ FlowFile Repository, if also on that disk, could 
become corrupt. To avoid this s
     
     |====
     |*Property*|*Description*
    -|nifi.content.repository.implementation|The Content Repository 
implementation. The default value is 
`org.apache.nifi.controller.repository.FileSystemRepository` and should only be 
changed with caution. To store flowfile content in memory instead of on disk 
(at the risk of data loss in the event of power/machine failure), set this 
property to `org.apache.nifi.controller.repository.VolatileContentRepository`.
    +|`nifi.content.repository.implementation`|The Content Repository 
implementation. The default value is 
`org.apache.nifi.controller.repository.FileSystemRepository` and should only be 
changed with caution. To store flowfile content in memory instead of on disk 
(at the risk of data loss in the event of power/machine failure), set this 
property to `org.apache.nifi.controller.repository.VolatileContentRepository`.
     |====
     
     === File System Content Repository Properties
     
     |====
     |*Property*|*Description*
    -|nifi.content.repository.implementation|The Content Repository 
implementation. The default value is 
`org.apache.nifi.controller.repository.FileSystemRepository` and should only be 
changed with caution. To store flowfile content in memory instead of on disk 
(at the risk of data loss in the event of power/machine failure), set this 
property to `org.apache.nifi.controller.repository.VolatileContentRepository`.
    -|nifi.content.claim.max.appendable.size|The maximum size for a content 
claim. The default value is `1 MB`.
    -|nifi.content.claim.max.flow.files|The maximum number of FlowFiles to 
assign to one content claim. The default value is `100`.
    -|nifi.content.repository.directory.default*|The location of the Content 
Repository. The default value is `./content_repository`. +
    +|`nifi.content.repository.implementation`|The Content Repository 
implementation. The default value is 
`org.apache.nifi.controller.repository.FileSystemRepository` and should only be 
changed with caution. To store flowfile content in memory instead of on disk 
(at the risk of data loss in the event of power/machine failure), set this 
property to `org.apache.nifi.controller.repository.VolatileContentRepository`.
    +|`nifi.content.claim.max.appendable.size`|The maximum size for a content 
claim. The default value is `1 MB`.
    +|`nifi.content.claim.max.flow.files`|The maximum number of FlowFiles to 
assign to one content claim. The default value is `100`.
    +|`nifi.content.repository.directory.default`*|The location of the Content 
Repository. The default value is `./content_repository`. +
      +
     *NOTE*: Multiple content repositories can be specified by using the 
*_nifi.content.repository.directory._* prefix with unique suffixes and separate 
paths as values. +
      +
     For example, to provide two additional locations to act as part of the 
content repository, a user could also specify additional properties with keys 
of: +
      +
    -nifi.content.repository.directory.content1=/repos/content1 +
    -nifi.content.repository.directory.content2=/repos/content2 +
    +`nifi.content.repository.directory.content1=/repos/content1` +
    +`nifi.content.repository.directory.content2=/repos/content2` +
      +
     Providing three total locations, including  
`nifi.content.repository.directory.default`.
    -|nifi.content.repository.archive.max.retention.period|If archiving is 
enabled (see nifi.content.repository.archive.enabled below), then
    +|`nifi.content.repository.archive.max.retention.period`|If archiving is 
enabled (see `nifi.content.repository.archive.enabled` below), then
     this property specifies the maximum amount of time to keep the archived 
data. The default value is `12 hours`.
    -|nifi.content.repository.archive.max.usage.percentage|If archiving is 
enabled (see nifi.content.repository.archive.enabled below), then this property 
must have a value that indicates the content repository disk usage percentage 
at which archived data begins to be removed. If the archive is empty and 
content repository disk usage is above this percentage, then archiving is 
temporarily disabled. Archiving will resume when disk usage is below this 
percentage. The default value is `50%`.
    -|nifi.content.repository.archive.enabled|To enable content archiving, set 
this to _true_ and specify a value for the 
`nifi.content.repository.archive.max.usage.percentage` property above. Content 
archiving enables the provenance UI to view or replay content that is no longer 
in a dataflow queue. By default, archiving is enabled.
    -|nifi.content.repository.always.sync|If set to `true`, any change to the 
repository will be synchronized to the disk, meaning that NiFi will ask the 
operating system not to cache the information. This is very expensive and can 
significantly reduce NiFi performance. However, if it is `false`, there could 
be the potential for data loss if either there is a sudden power loss or the 
operating system crashes. The default value is `false`.
    -|nifi.content.viewer.url|The URL for a web-based content viewer if one is 
available. It is blank by default.
    +`|`nifi.content.repository.archive.max.usage.percentage`|If archiving is 
enabled (see `nifi.content.repository.archive.enabled` below), then this 
property must have a value that indicates the content repository disk usage 
percentage at which archived data begins to be removed. If the archive is empty 
and content repository disk usage is above this percentage, then archiving is 
temporarily disabled. Archiving will resume when disk usage is below this 
percentage. The default value is `50%`.
    --- End diff --
    
    I think there is an accidental initial backtick before the column 
delimiter. 


> Edits needed for LDAP and Kerberos login identity provider sections in Admin 
> Guide
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-5469
>                 URL: https://issues.apache.org/jira/browse/NIFI-5469
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Documentation & Website
>            Reporter: Andrew Lim
>            Assignee: Andrew Lim
>            Priority: Minor
>
> Going through the Authentication and Authorization sections of the Admin 
> Guide, I noticed the following improvements could be made:
>  * Removed “Kerberos Config File” property from kerberos-provider login 
> identity provider (this was done because the same property exists in 
> nifi.properties)
>  * Corrected the "LDAP-based Users/Groups Referencing User Attribute” login 
> identity provider example to refer to “member uid"
>  * Added titles to login identity provider examples for improved 
> readability/search
>  * Changed UserGroupProvider property examples from bulleted lists to tables
> Also, text formatting for references to config files, directories, etc.  need 
> to be made consistent.  For example, config files like _nifi.properties_, 
> _authorizers.xml_ should be italicized.  Directories, properties and default 
> values for properties should be monospaced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to