[ 
https://issues.apache.org/jira/browse/NIFI-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560258#comment-16560258
 ] 

ASF GitHub Bot commented on NIFI-5469:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2922#discussion_r205885685
  
    --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
    @@ -3180,14 +3284,14 @@ In this example, Nginx is used as a reverse proxy.
     
     image:s2s-rproxy-servername.svg["Server name to Node mapping"]
     
    -1. Client1 initiates Site-to-Site protocol, the request is routed to one 
of upstream NiFi nodes. The NiFi node computes Site-to-Site port for RAW. By 
the routing rule 'example1' in nifi.properties shown below, port 10443 is 
returned.
    +1. Client1 initiates Site-to-Site protocol, the request is routed to one 
of upstream NiFi nodes. The NiFi node computes Site-to-Site port for RAW. By 
the routing rule 'example1' in _nifi.properties_ shown below, port 10443 is 
returned.
     2. Client1 asks peers to 'nifi.example.com:10443', the request is routed 
to 'nifi0:8081'. The NiFi node computes available peers, by 'example1' routing 
rule, 'nifi0:8081' is converted to 'nifi0.example.com:10443', so are nifi1 and 
nifi2. As a result, 'nifi0.example.com:10443', 'nifi1.example.com:10443' and 
'nifi2.example.com:10443' are returned.
     3. Client1 decides to use 'nifi2.example.com:10443' for further 
communication.
     4. On the other hand, Client2 has two URIs for Site-to-Site bootstrap 
URIs, and initiates the protocol using one of them. The 'example1' routing does 
not match this for this request, and port 8081 is returned.
     5. Client2 asks peers from 'nifi1:8081'. The 'example1' does not match, so 
the original 'nifi0:8081', 'nifi1:8081' and 'nifi2:8081' are returned as they 
are.
     6. Client2 decides to use 'nifi2:8081' for further communication.
     
    -Routing rule 'example1' is defined in nifi.properties (all node has the 
same routing configuration):
    +Routing rule 'example1' is defined in _nifi.properties_ (all node has the 
same routing configuration):
    --- End diff --
    
    "... all nodes **have** the same routing configuration):"


> Edits needed for LDAP and Kerberos login identity provider sections in Admin 
> Guide
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-5469
>                 URL: https://issues.apache.org/jira/browse/NIFI-5469
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Documentation & Website
>            Reporter: Andrew Lim
>            Assignee: Andrew Lim
>            Priority: Minor
>
> Going through the Authentication and Authorization sections of the Admin 
> Guide, I noticed the following improvements could be made:
>  * Removed “Kerberos Config File” property from kerberos-provider login 
> identity provider (this was done because the same property exists in 
> nifi.properties)
>  * Corrected the "LDAP-based Users/Groups Referencing User Attribute” login 
> identity provider example to refer to “member uid"
>  * Added titles to login identity provider examples for improved 
> readability/search
>  * Changed UserGroupProvider property examples from bulleted lists to tables
> Also, text formatting for references to config files, directories, etc.  need 
> to be made consistent.  For example, config files like _nifi.properties_, 
> _authorizers.xml_ should be italicized.  Directories, properties and default 
> values for properties should be monospaced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to