[
https://issues.apache.org/jira/browse/NIFI-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563083#comment-16563083
]
ASF GitHub Bot commented on NIFI-5471:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2926
NIFI-5471: Push table aliasing to DatabaseAdapter impls
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5471
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2926.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2926
----
commit f007889d7c7c42023a3ab876b2e59372308fc0cf
Author: Matthew Burgess <mattyb149@...>
Date: 2018-07-31T03:11:40Z
NIFI-5471: Push table aliasing to DatabaseAdapter impls
----
> QueryDatabaseTable does not correctly support arbitrary queries on Oracle
> -------------------------------------------------------------------------
>
> Key: NIFI-5471
> URL: https://issues.apache.org/jira/browse/NIFI-5471
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> NIFI-1706 added the capability to generate the "table" it uses for
> incremental fetch from a SQL statement, rather than generating it directly
> from "Columns to Return", "Max Value Columns", etc. When a SQL query is
> supplied, it is wrapped as a nested query in a SELECT, and the result is
> aliased to the provided "Table Name" property value.
> Currently this is done by simply generating a string "SELECT (" + query + ")
> AS " + tableName. However some databases (such as Oracle) do not allow the
> "AS" keywords for aliasing things like tables. The getWrappedQuery() method
> should delegate to the specified database adapter for generating a table
> alias clause. Many adapters will return "AS " + tableName, where the Oracle
> adapter(s) will simply return the table name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
