[ 
https://issues.apache.org/jira/browse/NIFI-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565678#comment-16565678
 ] 

ASF GitHub Bot commented on NIFI-4434:
--------------------------------------

GitHub user jtstorck opened a pull request:

    https://github.com/apache/nifi/pull/2930

    NIFI-4434 Fixed recursive listing with a custom regex filter.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jtstorck/nifi NIFI-4434

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2930
    
----
commit 26957eba6701d7d96e0a891031ddb05c4ff7598c
Author: Jeff Storck <jtswork@...>
Date:   2018-08-01T17:13:40Z

    NIFI-4434 Fixed recursive listing with a custom regex filter.

----


> ListHDFS applies File Filter also to subdirectory names in recursive search
> ---------------------------------------------------------------------------
>
>                 Key: NIFI-4434
>                 URL: https://issues.apache.org/jira/browse/NIFI-4434
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Holger Frydrych
>            Assignee: Jeff Storck
>            Priority: Major
>
> The File Filter regex configured in the ListHDFS processor is applied not 
> just to files found, but also to subdirectories. 
> If you try to set up a recursive search to list e.g. all csv files in a 
> directory hierarchy via a regex like ".*\.csv", it will only pick up csv 
> files in the base directory, not in any subdirectory. This is because 
> subdirectories don't typically match that regex pattern.
> To fix this, either subdirectories should not be matched against the file 
> filter, or the file filter should be applied to the full path of all files 
> (relative to the base directory). The GetHDFS processor offers both options 
> via a switch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to