[
https://issues.apache.org/jira/browse/NIFI-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566044#comment-16566044
]
ASF GitHub Bot commented on NIFI-5480:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2932
NIFI-5480: Use FlowController's maps of components in order to look u…
…p component by ID rather than iterating recursively through all Process
Groups to find the component
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5480
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2932.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2932
----
commit f794cf714d42b8f954b35869ee1e8369f62a6ca8
Author: Mark Payne <markap14@...>
Date: 2018-08-01T21:49:51Z
NIFI-5480: Use FlowController's maps of components in order to look up
component by ID rather than iterating recursively through all Process Groups to
find the component
----
> Improve efficiency of how components are looked up by Identifier
> ----------------------------------------------------------------
>
> Key: NIFI-5480
> URL: https://issues.apache.org/jira/browse/NIFI-5480
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
>
> When we lookup a component by ID, we do so by obtaining the Root Process
> Group and then calling {{findLocalConnectable(String id)}}. This method
> obtains a read lock, then checks its map of Processors, its map of Input
> Ports, its map of Output Ports, and its map of Funnels. If no match is found,
> it then calls getRemoteProcessGroups() to iterate over each of those, looking
> for a Remote Input/Output Port with that ID. This call to
> {{getRemoteProcessGroups()}} creates a new {{HashSet}} that is then returned.
> If no match is found, we then call {{getProcessGroups()}} which also creates
> a new {{HashSet}} of ProcessGroup objects, and we iterate over those
> (recursively).
> This means that for each call to lookup a component by ID, we have to create
> two {{HashSet}}s - for each Process Group on the canvas, until the component
> is found. Consider a flow that has a dozen Process Groups and several
> thousand Processors/ports/funnels. If we then click "Start" on the root
> group, we must create up to 24 {{HashSet}} objects and obtain 12 Read Locks.
> This is done for each component, so for 1,000 Processors it will create
> 24,000 {{HashSet}}s and obtain 12,000 Read Locks. Also, since this is a
> mutable request, this has to be done for both the first and second phase of
> the request, which results in a total of 48,000 {{HashSet}}s and 24,000 Read
> Locks being obtained.
> Testing with 10,000 Processors I am seeing requests take well over 30 seconds
> to complete. All just to find a component by identifier. We can make this
> much more efficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
